Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Support EnumTypes in error messages #5439

Merged
merged 1 commit into from
Jun 21, 2023

Conversation

youngar
Copy link
Member

@youngar youngar commented Jun 21, 2023

This adds support for enumeration types to getFieldName, which is commonly used to print the access path to a field in an aggregate. This function is used to report error messages in InferWidths.

Fixes #5324

This adds support for enumeration types to `getFieldName`, which is
commonly used to print the access path to a field in an aggregate.  This
function is used to report error messages in InferWidths.

Fixes llvm#5324
@youngar youngar added the FIRRTL Involving the `firrtl` dialect label Jun 21, 2023
@youngar youngar merged commit 30a7e7a into llvm:main Jun 21, 2023
@youngar youngar deleted the firrtl-enum-names branch June 21, 2023 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FIRRTL] crash, need getFieldName (and friends?) support for enums
1 participant