Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firtool 1.37] Enhanced Firtool Release Artifacts #5498

Merged

Conversation

jackkoenig
Copy link
Contributor

I would like this change on any firtool branches that may have longer term support, especially if they are used by Chisel, and Chisel 3.6.0 uses firtool 1.37.0.

This is just backporting some enhancements to 1.37:

Basically using v3 of some Github actions APIs and:

  • Add Windows (firtool.exe)
  • Remove Ubuntu 18.04 (runner is deprecated)
  • Name archives based on OS and architecture
    • linux-x64, macos-x64, linux-x64
    • Windows uses .zip, Linux and MacOS use .tar.gz
  • Add sha256 hashes for archives

dtzSiFive and others added 2 commits June 27, 2023 13:50
Node12 -> Node16, primarily.

See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ .

Appears safe, both have some improvements we may enjoy, such as zstd for Windows cache.
* Add Windows (firtool.exe)
* Remove Ubuntu 18.04 (runner is deprecated)
* Name archives based on OS and architecture
  * linux-x64, macos-x64, linux-x64
  * Windows uses .zip, Linux and MacOS use .tar.gz
* Add sha256 hashes for archives
@jackkoenig
Copy link
Contributor Author

I am testing this in https://github.com/jackkoenig/circt/releases/tag/firtool-1.37.1-ish (action: https://github.com/jackkoenig/circt/actions/runs/5394507193) Don't merge until we know it works. Especially because this is enabling check-mlir which was previously disabled.

Copy link
Member

@uenoku uenoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why LLVM tracker is invoked in normal PR. Otherwise changes looks good to me.

@jackkoenig jackkoenig merged commit 88acb43 into firtool-1.37 Jun 28, 2023
@jackkoenig jackkoenig deleted the jackkoenig/firtool-1.37/enhanced-release-artifacts branch July 28, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants