[FIRRTL] Export literal identifiers correctly #5502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
approved these changes
Jun 27, 2023
| StringRef str = attr.getValue(); | ||
| if (str.empty() || !isdigit(str.front())) | ||
| return attr; | ||
| return StringAttr::get(attr.getContext(), "`" + Twine(attr) + "`"); |
There was a problem hiding this comment.
I was going to suggest letting PrettyPrinter's string storage handle this for you (the thing PPExtString opts out of) instead of unique'ing into the context, but probably this is something already done as part of IR printing/etc., and also sufficiently rare to not matter.
| addValueName(arguments[i], port.name); | ||
| ps << PPExtString(port.name.getValue()) << " : "; | ||
| addValueName(arguments[i], legalize(port.name)); | ||
| ps << PPExtString(legalize(port.name)) << " : "; |
There was a problem hiding this comment.
(maybe not worth only calling legalize(port.name) once, as done elsewhere/later? Works for me!)
|
|
||
| // Test that literal identifiers work. | ||
| // CHECK-LABEL: module `0Bar` : | ||
| firrtl.module @"0Bar"( |
There was a problem hiding this comment.
Awesome test, so thorough I love it!! Thank you! 🚀
Update the FIRRTL exporter to properly escape literal identifiers. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/firrtl-export-literal-identifiers
branch
from
b47d594
to
7505388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the FIRRTL exporter to properly escape literal identifiers.