[FIRRTL] Verify OpenAggs, fix agg-of-properties. #5508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enforce general requirement that all elements of something implementing FieldIDTypeInterface must also support that interface. This is true for FIRRTLBaseType, but not necessarily true for all FIRRTLType's. Test using Property types which don't implement this. Fixes llvm#5494.
rwy7
reviewed
Jun 28, 2023
Per reviewer feedback, thanks!
rwy7
reviewed
Jun 28, 2023
| // We require that elements of aggregates themselves | ||
| // support notion of FieldID, reject if the type does not. | ||
| if (!isa<hw::FieldIDTypeInterface>(type)) | ||
| return emitError(loc, "bundle elements must support fieldID's, " |
There was a problem hiding this comment.
I don't think the user is going to understand fieldIDs, maybe just leave it at "type 'blah' cannot be used as a field in a bundle"?
(side thought, It would be nice if we could render the type in FIRRTL-syntax, hey)
There was a problem hiding this comment.
You're totally right, I'll tighten this up, thank you!
(And 100% would be great to be able to render as FIRRTL!
That could be shared with the FIRRTL exporter, maybe, too?)
Per reviewer feedback, thank you very much!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add verifiers for both MLIR and FIR + tests.
Fixes #5494 .