-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[LowerFIRRTLToHW] Create less wires with instance ports #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we lower input ports on instances, if there are zero or multiple writers to the input port, we create a wire and use that as the operand to the new instance operation. There was a change to this code to use `hw::WireOps`, which have their input value as an operand. Since `hw::WireOp`'s cannot have multiple writers, the code is now "the last writer wins". The wire's input is updated when processing connect-like operations - we will replace the previous writer to the wire. We already have a helper in this code to gracefully handle this situation called `createBackedge`. A backedge is a placeholder for a value which will be determined later. We can use a backedge as an operand to the lowered instance op, and when we find the connect operation driving a value to the old instance port, replace the backedge with the driven value. The backedge helper in this pass gracefully handles undriven backedges and combinational loops of backedges; if a backedge has not been replaced by the end of the module body, it will be replaced with an undriven wire. An assert had to be removed which prevented a backedge from being updated multiple times. Regular ~Connect ops were updated to support backedges, instead of just strict connects. This change is NFC in the FIRRTL pipeline, where the corner cases of combinational loops and undriven ports are illegal. This better supports the two illegal cases of undriven inputs and combinational loops. In the future we should replace all usages of `createTmpHWWireOp` with the backedge helpers.
fabianschuiki
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I love how this gets rid of another batch of temporary wires 🎉
dtzSiFive
approved these changes
Jun 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing improvement, LGTM!
This was referenced Jun 28, 2023
calebmkim
pushed a commit
to andrewb1999/circt
that referenced
this pull request
Jul 12, 2023
When we lower input ports on instances, if there are zero or multiple writers to the input port, we create a wire and use that as the operand to the new instance operation. There was a change to this code to use `hw::WireOps`, which have their input value as an operand. Since `hw::WireOp`'s cannot have multiple writers, the code is now "the last writer wins". The wire's input is updated when processing connect-like operations - we will replace the previous writer to the wire. We already have a helper in this code to gracefully handle this situation called `createBackedge`. A backedge is a placeholder for a value which will be determined later. We can use a backedge as an operand to the lowered instance op, and when we find the connect operation driving a value to the old instance port, replace the backedge with the driven value. The backedge helper in this pass gracefully handles undriven backedges and combinational loops of backedges; if a backedge has not been replaced by the end of the module body, it will be replaced with an undriven wire. An assert had to be removed which prevented a backedge from being updated multiple times. Regular connect ops were updated to support backedges, instead of just strict connects. This change is NFC in the FIRRTL pipeline, where the corner cases of combinational loops and undriven ports are illegal. This better supports the two illegal cases of undriven inputs and combinational loops. In the future we should replace all usages of `createTmpHWWireOp` with the backedge helpers.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we lower input ports on instances, if there are zero or multiple writers to the input port, we create a wire and use that as the operand to the new instance operation. There was a change to this code to use
hw::WireOps
, which have their input value as an operand. Sincehw::WireOp
's cannot have multiple writers, the code is now "the last writer wins". The wire's input is updated when processing connect-like operations - we will replace the previous writer to the wire.We already have a helper in this code to gracefully handle this situation called
createBackedge
. A backedge is a placeholder for a value which will be determined later. We can use a backedge as an operand to the lowered instance op, and when we find the connect operation driving a value to the old instance port, replace the backedge with the driven value.The backedge helper in this pass gracefully handles undriven backedges and combinational loops of backedges; if a backedge has not been replaced by the end of the module body, it will be replaced with an undriven wire.
An assert had to be removed which prevented a backedge from being updated multiple times. Regular connect ops were updated to support backedges, instead of just strict connects.
This change is NFC in the FIRRTL pipeline, where the corner cases of combinational loops and undriven ports are illegal. This better supports the two illegal cases of undriven inputs and combinational loops. In the future we should replace all usages of
createTmpHWWireOp
with the backedge helpers.