[InferWidths] Remove expensive walks, NFC #5523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the preprocess there seems to be an unintended use of `walk`. A walk in the post-order doesn't return early even when `skip()` was returned (see mlir/IR/Visitor.h). Probably pre-oreder was intended here. This comit just replaces walks with `getOps`.
dtzSiFive
approved these changes
Jun 30, 2023
|
Thank you for the review! |
calebmkim
pushed a commit
to andrewb1999/circt
that referenced
this pull request
Jul 12, 2023
In the preprocess there seems to be an unintended use of `walk`. Currently we walk the entire circuit three times in the pre-process. A walk in the post-order doesn't return early even when `skip()` was returned (see mlir/IR/Visitor.h). This commit just replaces walks with `getOps`. With this commit InferWidth should visit the entire IR only once.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the preprocess there seems to be an unintended use of
walk. Currently we walk the entire circuit three times in the pre-process. A walk in the post-order doesn't return early even whenskip()was returned (see mlir/IR/Visitor.h https://github.com/llvm/llvm-project/blob/ecfc2328ea8a1180170827d300674d0cf75a20d0/mlir/include/mlir/IR/Visitors.h#L280-L281). I think pre-order was actually intended behaivior there. This commit just replaces walks withgetOps. With this commit InferWidth should visit the entire IR only once.