Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTLFolds] Fix andr(pad(x:sint, n)) -> andr(x) canonicalization #5547

Merged
merged 1 commit into from
Jul 7, 2023
Merged

[FIRRTLFolds] Fix andr(pad(x:sint, n)) -> andr(x) canonicalization #5547

merged 1 commit into from
Jul 7, 2023

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jul 7, 2023 •
edited
Loading

This fixes a bug that andr(pad(x:sint, n)) is canonicalized into 0.

@uenoku uenoku merged commit 08b4071 into main Jul 7, 2023
@uenoku uenoku deleted the dev/uenoku/fix-cano branch July 7, 2023 11:44
calebmkim pushed a commit to andrewb1999/circt that referenced this pull request Jul 12, 2023
@uenoku @calebmkim
[FIRRTLFolds] Fix andr(pad(x:sint, n)) -> andr(x) canonicalization (l…
09103db 
…lvm#5547)

This fixes a bug that `andr(pad(x:sint, n))` is canonicalized into `0`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@uenoku