[LowerFirMem] Insert memory modules before first user #5587
+31
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `LowerFirMem` pass inserts `HWModuleGeneratedOp`s all the way at the top of the file. This is problematic since passes like FIRRTL's `LowerToHW` will produce an SV preamble with macro definitions that the memories want to rely on. Inserting the memory modules at the top of the file puts them before the macro definitions that they rely on. This commit changes the insertion point of memory modules, making them appear as late as possible in the IR, basically just before the first module that instantiates the memory. This ensures that the memory modules are always placed after that preamble and makes their location more logical within the IR.
fabianschuiki
added
FIRRTL
jackkoenig
approved these changes
Jul 13, 2023
Yeah that happens later should just work. That emission mode has some separate logic that replicates the macros for each output file, but keeps the IR in the same order. |
fabianschuiki
deleted the
fschuiki/fix-lower-firmem-module-insertion-point
branch
darthscsi
reviewed
Jul 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
LowerFirMempass insertsHWModuleGeneratedOps all the way at the top of the file. This is problematic since passes like FIRRTL'sLowerToHWwill produce an SV preamble with macro definitions that the memories want to rely on. Inserting the memory modules at the top of the file puts them before the macro definitions that they rely on.This commit changes the insertion point of memory modules, making them appear as late as possible in the IR, basically just before the first module that instantiates the memory. This ensures that the memory modules are always placed after that preamble and makes their location more logical within the IR.