[FIRRTL][LowerTypes] Support per-field inner symbols. #5610
+139
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darthscsi
approved these changes
Jul 19, 2023
dtzSiFive
force-pushed
the
feature/lowertypes-innersym
branch
from
cb2919d
to
ba0391d
Compare
Only error if their target is not included in lowered output. Partiton inner symbols to the lowered fields, error if any symbols target fieldID's not present in lowered form. (e.g., fieldID == 0).
Per reviewer feedback, thanks!
TypeSwitch to get access to getIndexAndSubfieldID. This will do binary searches to find index for fieldID in bundles (presently), vs previous impl linear walk of fields (each has pros/cons).
dtzSiFive
force-pushed
the
feature/lowertypes-innersym
branch
from
ba0391d
to
6f783b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only error if their target is not included in lowered output.
Partiton inner symbols to the lowered fields, error if any symbols target fieldID's not present in lowered form.
(e.g., fieldID == 0).