[FIRRTL][GrandCentral] Stop using ModuleNamespace for unique names #5619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
reviewed
Jul 18, 2023
ModuleNamespace is used for tracking used and generating new `inner_sym`s. This code is mistakenly using it to generate unique `name`s for wires and ports. It does not matter if the port has a unique name, as it will be legalized later in the pipeline.
youngar
force-pushed
the
firrtl-properties
branch
from
f3a9343
to
52b6c14
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ModuleNamespace is used for tracking used and generating new
inner_syms. This code is mistakenly using it to generate uniquenames for wires and ports. It does not matter if the port has a unique name, as it will be legalized later in the pipeline.