Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][FIRParser] Parse rwprobe of port into RWProbeOp. #5670

Merged
merged 3 commits into from
Jul 28, 2023
Merged

[FIRRTL][FIRParser] Parse rwprobe of port into RWProbeOp. #5670

merged 3 commits into from
Jul 28, 2023

Conversation

dtzSiFive
Copy link
Contributor

Add basic tests.

@dtzSiFive dtzSiFive added the FIRRTL Involving the `firrtl` dialect label Jul 24, 2023
@dtzSiFive dtzSiFive force-pushed the dev/dtz/rwprobe-op-parse branch 2 times, most recently from 8020976 to 6e27b10 Compare July 25, 2023 16:03
Base automatically changed from dev/dtz/rwprobe-op to main July 25, 2023 21:29
@dtzSiFive
Copy link
Contributor Author

Thank you for the review! Taking a different direction during parsing but your feedback will be incorporated in the new parsing PR.

@dtzSiFive dtzSiFive closed this Jul 26, 2023
@dtzSiFive dtzSiFive mentioned this pull request Jul 26, 2023
Closed
@dtzSiFive
[FIRRTL][FIRParser] Parse rwprobe of port into RWProbeOp.
1843a08 
Add basic tests.
@dtzSiFive
[FIRRTL][FIRParser] Use maintained ModuleNamespace instead of recalc.
82205e8 
Promote the mostly-unused `modNameSpace` to the more narrow
`ModuleNamespace` to match inner symbol API needs (for now),
avoid rebuilding when building rwprobe op's.

RWProbeOp's are the only entities parser adds inner symbols to
presently, FWIW.
@dtzSiFive
[FIRRTL][FIRParser] improve message phrasing!
f179803 
Per reviewer feedback, thanks!
@dtzSiFive dtzSiFive reopened this Jul 28, 2023
@dtzSiFive
Copy link
Contributor Author

cc #5004

@dtzSiFive dtzSiFive merged commit e59e3cf into main Jul 28, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the dev/dtz/rwprobe-op-parse branch July 28, 2023 15:14
@dtzSiFive dtzSiFive mentioned this pull request May 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge left review comments

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @seldridge