Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Make DropConst circuit op pass, NFC #5684

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented Jul 26, 2023

It's illegal to modify port types within FModuleLike pass so change DropConst pass to a circuit op pass.

It's illegali to modify port types within FModuleLike pass
@uenoku uenoku merged commit d70d21d into main Jul 26, 2023
5 checks passed
@uenoku uenoku deleted the dev/uenoku/fix-const-drop branch July 26, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant