[ExportVerilog] Use wire for inlined op operand #5695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
dev/seldridge/issue-5605
branch
from
039b98b
to
d11cc73
Compare
mikeurbach
approved these changes
Jul 27, 2023
Move a static function so that this can be used by an ealier static function in a later commit. This commit is broken out to make an actual functional change obvious in a later commit. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Plumb a LoweringOptions const reference to more functions. This is done in preparation for a functional change in a later commit. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Fix a bug where an assertion could fire in ExportVerilog due incomplete wire creation in PrepareForEmission. This bug occurss if an always inline operation was duplicated, but its operand is not always inline. This creates a situation where, if you were to run PrepareForEmission _again_, it would create a wire (and no assertion would fire). Change the logic when recursing through operands of an always inline operation to create this wire. Fixes #5605. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/issue-5605
branch
from
d11cc73
to
dbc043f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a bug where an assertion could fire in ExportVerilog due incomplete
wire creation in PrepareForEmission. This bug occurss if an always inline
operation was duplicated, but its operand is not always inline. This
creates a situation where, if you were to run PrepareForEmission again,
it would create a wire (and no assertion would fire).
Change the logic when recursing through operands of an always inline
operation to create this wire.
Fixes #5605.
This PR does some NFC monkeying with
PrepareForEmission. The first two commits do this NFC monkeying. The third commit makes the change and adds tests. For the purposes of PR review, only the last commit matters.