Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Remove {circuit,module}Target from FIRParser #5712

Merged
merged 1 commit into from
Jul 28, 2023
Merged

[FIRRTL] Remove {circuit,module}Target from FIRParser #5712

merged 1 commit into from
Jul 28, 2023

Conversation

rwy7
Copy link
Contributor

@rwy7 rwy7 commented Jul 28, 2023

These values aren't used anymore.

@dtzSiFive
Copy link
Contributor

Awesome, was honestly just looking at this myself! Thanks!

seldridge
seldridge approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup. Thanks!

@rwy7 rwy7 merged commit 9968966 into llvm:main Jul 28, 2023
5 checks passed
@rwy7 rwy7 deleted the parse-refactor branch July 28, 2023 13:05
@rwy7 rwy7 added the FIRRTL Involving the `firrtl` dialect label Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

Assignees
No one assigned
Labels
FIRRTL Involving the `firrtl` dialect
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rwy7 @dtzSiFive @seldridge