Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL][SFCTests] Fixup dedup tests. #5720

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Conversation

dtzSiFive
Copy link
Contributor

Fixes #4004.

Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looping back to check on XFAIL tests. 👍

Comment on lines -331 to +332
; CHECk-NEXT: firrtl.wire {annotations = [{circt.nonlocal = @[[nlaSym]], class = "circt.test"}]}
; CHECK-NEXT: firrtl.wire {annotations = [{circt.nonlocal = @[[nlaSym]], class = "circt.test"}]}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doh

@dtzSiFive
Copy link
Contributor Author

Had to change the tests a bit, hopefully checking what they're supposed to. Step forward anyway 👍 .

@dtzSiFive dtzSiFive merged commit 01442d1 into llvm:main Jul 28, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the fix/dedup-tests branch July 28, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revisit dedup-errors.fir XFAIL'd test
2 participants