[circt-reduce] Add FIRRTL name sanitization #5723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
changed the base branch from
main
to
dev/seldridge/circt-reduce-operation-forwarder-one-operand
fabianschuiki
approved these changes
Jul 29, 2023
Comment on lines
+1000
to
+1007
| const char *names[48] = { | ||
| "Foo", "Bar", "Baz", "Qux", "Quux", "Quuux", "Quuuux", | ||
| "Quz", "Corge", "Grault", "Bazola", "Ztesch", "Thud", "Grunt", | ||
| "Bletch", "Fum", "Fred", "Jim", "Sheila", "Barney", "Flarp", | ||
| "Zxc", "Spqr", "Wombat", "Shme", "Bongo", "Spam", "Eggs", | ||
| "Snork", "Zot", "Blarg", "Wibble", "Toto", "Titi", "Tata", | ||
| "Tutu", "Pippo", "Pluto", "Paperino", "Aap", "Noot", "Mies", | ||
| "Oogle", "Foogle", "Boogle", "Zork", "Gork", "Bork"}; |
seldridge
changed the base branch from
dev/seldridge/circt-reduce-operation-forwarder-one-operand
to
main
Move the SymbolCache struct used by the FIRRTL circt-reduce library into its own "detail" namespace to avoid future conflicts with SymbolCache inside FIRRTLUtils.h. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Add two new pseudo-reduction patterns: - module-name-sanitizer - module-internal-name-sanitizer These are not true reductions as they only do cleanup of the circuit. However, they make a number of modifications which are typically made by a circt-reduce user before sharing the result of a circt-reduce run: - All internal names are converted to generic names - All modules are replaced with metasyntactic names These have the lowest priority, are one-shot, and will accept a larger circuit result (even though they should almost always produce a smaller output). Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
seldridge
force-pushed
the
dev/seldridge/circt-reduce-name-sanitizer
branch
from
b24f2b0
to
1a45ea5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two new pseudo-reduction patterns:
These are not true reductions as they only do cleanup of the circuit.
However, they make a number of modifications which are typically made by a
circt-reduce user before sharing the result of a circt-reduce run:
These have the lowest priority, are one-shot, and will accept a larger
circuit result (even though they should almost always produce a smaller
output).