Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][FIRParser] BigInt -> Integer . #5734

Merged
merged 1 commit into from
Jul 31, 2023
Merged

[FIRRTL][FIRParser] BigInt -> Integer . #5734

merged 1 commit into from
Jul 31, 2023
+16 −16

Conversation

dtzSiFive
Copy link
Contributor

Leave internal (C++) name alone for now,
may want to call it something other than IntegerType to ensure it's sufficiently distinct (e.g., mlir::IntegerType).

@dtzSiFive
[FIRRTL][FIRParser] BigInt -> Integer .
dde991b 
Leave internal (C++) name alone for now,
may want to call it something other than IntegerType
to ensure it's sufficiently distinct (e.g., mlir::IntegerType).
mikeurbach
mikeurbach approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me, thanks. I guess separately, we can update the parser to respect that these and propassign are a FIRRTL 3.1.0 construct.

@dtzSiFive
Copy link
Contributor Author

Nice, looks good to me, thanks. I guess separately, we can update the parser to respect that these and propassign are a FIRRTL 3.1.0 construct.

PR coming w/that shortly, was going to include but since touches non-Integer (bigint) things seemed better to address separately 👍 .
(no sense gating Integer but not propassign, etc.)

@dtzSiFive dtzSiFive merged commit 68f3e7f into llvm:main Jul 31, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the fix/bigint-is-integer-in-firrtl-spec branch July 31, 2023 20:28
youngar
youngar approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@youngar youngar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youngar youngar youngar approved these changes

@mikeurbach mikeurbach mikeurbach approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzSiFive @mikeurbach @youngar