Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HW][InnerSym] Use uint64_t for method names involving FieldID. #5739

Merged
merged 1 commit into from
Aug 1, 2023
Merged

[HW][InnerSym] Use uint64_t for method names involving FieldID. #5739

merged 1 commit into from
Aug 1, 2023

Conversation

dtzSiFive
Copy link
Contributor

Until standardize on a dedicated type, fix this.

@dtzSiFive
[HW][InnerSym] Use uint64_t for method names involving FieldID.
0db73fc 
Until standardize on a dedicated type, fix this.
teqdruid
teqdruid approved these changes Jul 31, 2023
View reviewed changes
Copy link
Contributor

@teqdruid teqdruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this fixes some warnings? Seems like it's NFC.

seldridge
seldridge approved these changes Aug 1, 2023
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And yes, we should be using uint64_t for all of these.

@dtzSiFive
Copy link
Contributor Author

Basically NFC, aligns these methods with the type used for fieldID's within InnerSym's and elsewhere re:FieldIDTypeInterface (uint64_t), cc #4443 .

Thanks, all!

@dtzSiFive dtzSiFive merged commit 2028396 into llvm:main Aug 1, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the fix/inner-sym-fields-are-64bit branch August 1, 2023 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teqdruid teqdruid teqdruid approved these changes

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dtzSiFive @seldridge @teqdruid