Abstract out PortList from HWModuleLike #5749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements a parser for a new module style. This module style uses ModuleType to store it's ports. This allows maininging port order. The added HWTestModuleOp is temporary to allow development until moving all the modules over.
darthscsi
requested review from
dtzSiFive,
Dinistro,
mortbopet,
lucas-rami,
seldridge,
teqdruid,
rachitnigam,
cgyurgyik,
mikeurbach,
andrewb1999,
fabianschuiki and
maerhart
as code owners
teqdruid
reviewed
Aug 1, 2023
| //===------------------------------------------------------------------===// | ||
| // PortList Methods | ||
| //===------------------------------------------------------------------===// | ||
| ::circt::hw::ModulePortInfo getPortList(); |
There was a problem hiding this comment.
Isn't this redundant? I would imagine this method is already declared via DeclareOpInterfaceMethods<HWModuleLike>.
There was a problem hiding this comment.
It is not. And if it were, it would be a compile error (duplicate definition).
teqdruid
approved these changes
Aug 1, 2023
| @@ -29,6 +29,7 @@ include "mlir/Interfaces/SideEffectInterfaces.td" | |||
| /// the module-like operations. | |||
| class HWModuleOpBase<string mnemonic, list<Trait> traits = []> : | |||
| HWOp<mnemonic, traits # [ | |||
| DeclareOpInterfaceMethods<PortList>, | |||
| DeclareOpInterfaceMethods<HWModuleLike>, | |||
| DeclareOpInterfaceMethods<HWMutableModuleLike>, | |||
There was a problem hiding this comment.
Ok... Having all three of these is redundant, right? HWMutableModuleLike should be enough, right?
There was a problem hiding this comment.
I'm not entirely sure, but it seemed in some tests that interface inheritance didn't obviously connect to the declaring methods. I was also able to get weird (invalid) stuff out of tblgen, so I'm not sure this feature is heavily tested yet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking up #5738