[FIRRTL] RWProbeOp: support width inference. #5782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikeurbach
reviewed
Aug 9, 2023
dtzSiFive
force-pushed
the
feature/rwprobe-op-infer-widths
branch
from
bb48da5
to
18d1b8e
Compare
Rework RWProbeOp to explicitly track result type, don't "infer" from target type argument (removed). This is a better fit for this op, particualrly in that no useful "inference" is performed that way. (not inferring through symbol target) Teach InferWidths about the type constraint, getting inner symbol analysis for resolution. Loosen parsing, but still only use RWProbeOp for ports. With these changes, it's nearly possible to remove "Forceable" entirely in favor of the one mechanism.
dtzSiFive
force-pushed
the
feature/rwprobe-op-infer-widths
branch
from
18d1b8e
to
4e7f229
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rework RWProbeOp to explicitly track result type,
don't "infer" from target type argument (removed).
This is a better fit for this op, particualrly in that no
useful "inference" is performed that way.
(not inferring through symbol target)
Teach InferWidths about the type constraint,
getting inner symbol analysis for resolution.
Loosen parsing, but still only use RWProbeOp
for ports.
With these changes, it's nearly possible to remove
"Forceable" entirely in favor of the one mechanism.