[FIRRTL] Reject unsupported port symbols on instance + class ops. #5796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
force-pushed
the
fix/no-port-syms-on-instances-and-class
branch
from
da1576e
to
95fb34d
Compare
uenoku
approved these changes
Aug 8, 2023
| @@ -1463,9 +1466,10 @@ ParseResult ClassOp::parse(OpAsmParser &parser, OperationState &result) { | |||
| SmallVector<Attribute, 4> portAnnotations; | |||
| SmallVector<Attribute, 4> portSyms; | |||
There was a problem hiding this comment.
It would be nice if we don't have to declare portSyms but the current implementation makes sense (maybe we can use std::optinal<SmallVectorImpl<Attribute>&> but would be messier).
There was a problem hiding this comment.
Agreed! With all the in-flight module/port reworkings I vote leave this as-is and revisit in a bit. But yes this could be improved!
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5788.