Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Seq] Add an inner symbol to permit references to clock gates #5799

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

nandor
Copy link
Contributor

@nandor nandor commented Aug 8, 2023

The inner symbol of a clock gate translates to an inner symbol on the instance it lowers to. Also slightly adjusted the lowering to cache constants and produce more readable test output.

include/circt/Dialect/Seq/SeqOps.td Outdated Show resolved Hide resolved
lib/Dialect/Seq/SeqOps.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, re:op + inner symbol usage.

lib/Dialect/Seq/Transforms/ExternalizeClockGate.cpp Outdated Show resolved Hide resolved
lib/Dialect/Seq/Transforms/ExternalizeClockGate.cpp Outdated Show resolved Hide resolved
The inner symbol of a clock gate translates to an inner symbol on the instance it lowers to.
Also slightly adjusted the lowering to cache constants and produce more readable test output.
@nandor nandor merged commit 627042f into main Aug 8, 2023
5 checks passed
@nandor nandor deleted the dev/nandor/clock-gate-sym branch August 8, 2023 17:13
@fabianschuiki
Copy link
Contributor

Thanks for adding this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants