New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL][NFCI] Cleanup misc "inner_sym" uses. #5802

Merged

dtzSiFive merged 1 commit into llvm:main from dtzSiFive:fix/minor-inner-sym-touchups

Aug 8, 2023

+6 −7

Contributor

dtzSiFive commented Aug 8, 2023

No description provided.


          [FIRRTL][NFCI] Cleanup misc "inner_sym" uses.

e74f3f4

dtzSiFive requested review from darthscsi and seldridge as code owners

August 8, 2023 15:22

dtzSiFive merged commit 7689b0e into llvm:main

5 checks passed

dtzSiFive deleted the fix/minor-inner-sym-touchups branch

August 8, 2023 15:55

seldridge reviewed

View reviewed changes

Member

seldridge left a comment

Great! This is paying down tech debt. And thanks for your vigilance in watching for uses of bare string getAttr/setAttr in new code. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet