Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Add Double property type. #6167

Merged
merged 5 commits into from
Sep 21, 2023
Merged

[FIRRTL] Add Double property type. #6167

merged 5 commits into from
Sep 21, 2023

Conversation

dtzSiFive
Copy link
Contributor

@dtzSiFive dtzSiFive commented Sep 21, 2023 •
edited
Loading

Double-precision floating point type.

Add attribute, constant op, and parse + emit support.

Only support what we understand as floatingpoint in lexer for now, which includes exponent notation.

Add support to LowerClasses.

mikeurbach
mikeurbach approved these changes Sep 21, 2023
View reviewed changes
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, looks good to me, thanks!

@dtzSiFive dtzSiFive merged commit 32c1db2 into llvm:main Sep 21, 2023
5 checks passed
@dtzSiFive dtzSiFive deleted the feature/firrtl-double branch September 21, 2023 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeurbach mikeurbach mikeurbach approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dtzSiFive @mikeurbach