[FIRRTL][ExpandWhens] Support flow checking for local and remote objects #6212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtzSiFive
reviewed
Sep 27, 2023
rwy7
force-pushed
the
classes-exand-whens
branch
2 times, most recently
from
07b8a48
to
7934d8d
Compare
dtzSiFive
approved these changes
Sep 28, 2023
| @@ -494,7 +494,8 @@ FieldRef circt::firrtl::getDeltaRef(Value value, bool lookThroughCasts) { | |||
| return FieldRef(); | |||
| return FieldRef(op.getInput(), 0); | |||
| }) | |||
| .Case<SubfieldOp, OpenSubfieldOp, SubindexOp, OpenSubindexOp, RefSubOp>( | |||
| .Case<SubfieldOp, OpenSubfieldOp, SubindexOp, OpenSubindexOp, RefSubOp, | |||
| ObjectSubfieldOp>( | |||
Gets us slightly better error messages for flow checking as a result.
rwy7
force-pushed
the
classes-exand-whens
branch
3 times, most recently
from
026f6e5
to
054dd41
Compare
rwy7
force-pushed
the
classes-exand-whens
branch
from
054dd41
to
302fe57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objects can be classified as either local or remote. A local object is an actual firrtl.object declaration in the current scope. A remote object would be a class-typed port (of either the current module/class, or an instance/object).
For local objects, we are obligated to initialize their input ports. Sink-flow remote objects must be initialized by assigning to the entire thing, at the root.
This PR does a few things: