[SV] Mark sv.xmr.ref op as pure #6260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Having an `sv.xmr.ref` ops inside a procedural block such as `sv.alwayscomb` triggers an assertion in `PrepareForEmission`. The pass would identify the ref op as having side-effects and then go ahead and try to pull it outside the procedural block. Doing so would create a `sv.reg` op with multiple nested inout types, which breaks. Fix the issue by marking the `sv.xmr.ref` op as pure. Taking a reference to something does not have a side-effect. It's accessing what's behind the reference that has side-effects.
seldridge
approved these changes
Oct 5, 2023
| def XMRRefOp : SVOp<"xmr.ref", [ | ||
| DeclareOpInterfaceMethods<SymbolUserOpInterface>, | ||
| Pure | ||
| ]> { |
fabianschuiki
commented
Oct 5, 2023
dtzSiFive
approved these changes
Oct 5, 2023
fabianschuiki
commented
Oct 5, 2023
fabianschuiki
commented
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having an
sv.xmr.refop inside a procedural block such assv.alwayscombtriggers an assertion inPrepareForEmission. The pass would identify the ref op as having side-effects and then go ahead and try to pull it outside the procedural block. Doing so would create asv.regop with multiple nested inout types, which breaks.Fix the issue by marking the
sv.xmr.refop as pure. Taking a reference to something does not have a side-effect. It's accessing what's behind the reference that has side-effects.