Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL][CAPI] Add functions for property types #6413

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

SpriteOvO
Copy link
Member

This PR adds FIRRTL C-API functions for property type, which are necessary for chipsalliance/chisel#3626.

I found that the port direction enum can be reused in the FIRRTLClassElement struct, so I renamed the enum and enumerations for that purpose. Since Chisel is probably the only user for now, I think the API breaking change might not be a big deal?

Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new APIs for property types look good to me.

I found that the port direction enum can be reused in the FIRRTLClassElement struct, so I renamed the enum and enumerations for that purpose.

This makes sense to me.

lib/CAPI/Dialect/FIRRTL.cpp Outdated Show resolved Hide resolved
@SpriteOvO
Copy link
Member Author

SpriteOvO commented Nov 14, 2023

@mikeurbach Thanks for your review ^^. Typo has been fixed and branch has been rebased, waiting for CI done.

@SpriteOvO SpriteOvO merged commit e118358 into llvm:main Nov 14, 2023
4 checks passed
@SpriteOvO SpriteOvO deleted the firrtl-property-capi branch November 14, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants