[LowerToHW] Fix output port index mapping #6530
Merged
+31
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prithayan
requested review from
darthscsi,
dtzSiFive and
seldridge
as code owners
|
It might be good to keep the port mapping in the portinfo like lowering info. I think I do something like this in lowersigs. |
Good idea, to avoid similar issues. |
|
💯 , thanks Prithayan! And yeah totally the port lowering probably should be reworked a bit as well and if two separate bits of code have assumptions about ordering details that should be captured and used instead of implicit in the code. Thanks for identifying the problem + quick fix! |
mikeurbach
pushed a commit
that referenced
this pull request
Dec 21, 2023
The logic that was moving the symbol from the port to the wire was incorrectly assuming that all the output ports are ordered after the input ports, this resulted in the port index mapping being incorrect. This was causing the incorrect port symbol being moved to a temporary wire. This commit fixes the port index calculation logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LowerToHWlogic that was moving the symbol from the port to the wire was incorrectly assuming that all the output ports are ordered after the input ports, this resulted in the port index mapping being incorrect.This was causing the incorrect port symbol being moved to a temporary wire.
Fix the port index calculation logic.