[FIRRTL][NFC] Use underscores in documentation. #6860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the only supported mechanism for using intrinsics, the name must be an identifier so just document that. Periods are nice, we can adjust the FIRRTL grammar / syntax to allow this in the future if we miss them.
dtzSiFive
force-pushed
the
feature/intrinsic-underscores
branch
from
d04493f
to
3a924f9
Compare
|
(this is true of |
dtzSiFive
added
documentation
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
In the only supported mechanism for using intrinsics, the name must be an identifier so just document that. Periods are nice, we can adjust the FIRRTL grammar / syntax to allow this in the future if we miss them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the only supported mechanism for using intrinsics, the name must be an identifier so just document that.
Periods are nice, we can adjust the FIRRTL grammar / syntax to allow this in the future if we miss them.
This does not modify the code internally that looks for the dot syntax.