[NFC] Massive Export Verilog Speedup #6886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting all the ports to lookup one attribute is very expensive. Mainly from GetAllPortLocs requiring several lookups and allocations. Just avoid doing this by not using the summary functions and looking up individual ports directly (as should generally be done to avoid the overly broad expensive functions).
seldridge
approved these changes
Apr 1, 2024
Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
dtzSiFive
approved these changes
Apr 1, 2024
There was a problem hiding this comment.
Change LGTM but just seconding that yes this points out there's definitely room for improvement so we don't have to hand-roll this sort of thing to avoid performance bugs lurking in the friendlier accessors.
This and the internal use of deprecated accessors, let's see if we can't chart a path out and see this through 👍 .
Thanks for work on all this, and of course specifically for tracking this down and fixing it!
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
Getting all the ports to lookup one attribute is very expensive. Mainly from GetAllPortLocs requiring several lookups and allocations. Just avoid doing this by not using the summary functions and looking up individual ports directly (as should generally be done to avoid the overly broad expensive functions).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting all the ports to lookup one attribute is very expensive. Mainly from GetAllPortLocs requiring several lookups and allocations. Just avoid doing this by not using the summary functions and looking up individual ports directly (as should generally be done to avoid the overly broad expensive functions). Granted that getPort goes through the summary functions isn't obvious or ideal. It should be fixed.