Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Cache common lookups in ModuleType #6892

Merged
merged 2 commits into from
Apr 2, 2024
Merged

Conversation

darthscsi
Copy link
Contributor

Use custom storage for ModuleType to cache input/output <-> index mappings. Speeds up many things in small ways.

Use custom storage for ModuleType to cache input/output <-> index mappings.  Speeds up many things in small ways.
Copy link
Contributor

@mikeurbach mikeurbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, looks good to me.

include/circt/Dialect/HW/HWTypes.h Outdated Show resolved Hide resolved
include/circt/Dialect/HW/HWTypes.h Outdated Show resolved Hide resolved
@darthscsi darthscsi merged commit f77c002 into main Apr 2, 2024
3 of 4 checks passed
@darthscsi darthscsi deleted the dev/darthscsi/fast_modtype branch April 11, 2024 17:14
cepheus69 pushed a commit to cepheus69/circt that referenced this pull request Apr 22, 2024
Use custom storage for ModuleType to cache input/output <-> index mappings.  Speeds up many things in small ways.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants