[FIRRTL] Fixup visit ops miscategorized. #6896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FPGAProbeIntrinsicOp is not an expression (not pure and no results!), mlir::UnrealizedConversionCast is only sometimes expression-like (and FIRRTLVisitor is for visiting FIRRTL-dialect operations only), and GenericIntrinsicOp is neither expression nor statement so just add a special visitor for it. Update passes using visitors to reflect these changes.
dtzSiFive
force-pushed
the
feature/firrtl-visitor-touchups
branch
from
5779a30
to
d9c42a0
Compare
mikeurbach
approved these changes
Apr 4, 2024
|
Thanks, all! |
cepheus69
pushed a commit
to cepheus69/circt
that referenced
this pull request
Apr 22, 2024
FPGAProbeIntrinsicOp is not an expression (not pure and no results!), mlir::UnrealizedConversionCast is only sometimes expression-like (and FIRRTLVisitor is for visiting FIRRTL-dialect operations only), and GenericIntrinsicOp is neither expression nor statement so just add a special visitor for it. Update passes using visitors to reflect these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FPGAProbeIntrinsicOp is not an expression (not pure and no results!), mlir::UnrealizedConversionCast is only sometimes expression-like (and FIRRTLVisitor is for visiting FIRRTL-dialect operations only), and GenericIntrinsicOp is neither expression nor statement so just add a special visitor for it.
Update passes using visitors to reflect these changes.