Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIRRTL] Use a flag to implement scalarization of internal modules. … #6901

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

darthscsi
Copy link
Contributor

…This is precursor to making lower-types a module-pass and optional. This will deprecate the flags to lower-types and make aggregate preservation a function of NOT running lower-types, rather than having to control it to ensure ports are correct.

…his is precursor to making lower-types a module-pass and optional. This will deprecate the flags to lower-types and make aggregate preservation a function of NOT running lower-types, rather than having to control it to ensure ports are correct.
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@darthscsi darthscsi merged commit a25118c into main Apr 8, 2024
4 checks passed
@darthscsi darthscsi deleted the dev/darthscsi/intsig branch April 11, 2024 17:14
cepheus69 pushed a commit to cepheus69/circt that referenced this pull request Apr 22, 2024
…his is precursor to making lower-types a module-pass and optional. This will deprecate the flags to lower-types and make aggregate preservation a function of NOT running lower-types, rather than having to control it to ensure ports are correct. (llvm#6901)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants