Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIRRTL] Preserve all analysis if nothing happens #7077

Merged
merged 1 commit into from
May 22, 2024
Merged

[FIRRTL] Preserve all analysis if nothing happens #7077

merged 1 commit into from
May 22, 2024

Conversation

uenoku
Copy link
Member

@uenoku uenoku commented May 22, 2024 •
edited
Loading

LowerMatchesPass and MemOfVec should preserve analysis if nothing happens.

dtzSiFive
dtzSiFive approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

LowerMatch could grow a statistic to count how many it lowers in the future, if we wanted. Not for this PR.

@uenoku uenoku merged commit 9060f58 into main May 22, 2024
4 checks passed
@uenoku uenoku deleted the dev/hidetou/pre branch May 22, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@darthscsi darthscsi Awaiting requested review from darthscsi darthscsi is a code owner

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uenoku @dtzSiFive