Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC, FIRRTL] Rename StrictConnect to MatchingConnect. #7116

Merged
merged 3 commits into from
Jun 4, 2024
Merged

[NFC, FIRRTL] Rename StrictConnect to MatchingConnect. #7116

merged 3 commits into from
Jun 4, 2024

Conversation

darthscsi
Copy link
Contributor

This is to reserve "Strict" for LHSType connects in the future.

@darthscsi
[NFC, FIRRTL] Rename StrictConnect to MatchingConnect. This is to res…
cacdfc5 
…erve "Strict" for LHSType connects in the future.
@darthscsi darthscsi mentioned this pull request Jun 3, 2024
Merged
prithayan
prithayan approved these changes Jun 3, 2024
View reviewed changes
Copy link
Contributor

@prithayan prithayan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@darthscsi darthscsi merged commit 7e60fb9 into main Jun 4, 2024
4 checks passed
@darthscsi darthscsi deleted the dev/darthscsi/matchingconnect branch June 4, 2024 14:19
dtzSiFive added a commit that referenced this pull request Jun 4, 2024
@dtzSiFive
[FIRRTL][NFC] Fix leftover strictconnect -> matchingconnect .
bc5e9f3 
cc #7116.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prithayan prithayan prithayan approved these changes

@dtzSiFive dtzSiFive Awaiting requested review from dtzSiFive

@seldridge seldridge Awaiting requested review from seldridge seldridge is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@darthscsi @prithayan