[FIRRTL][ExportVerilog] Emit integers on DPI function as two state C-compatible types and clarify ABI #7163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uenoku
requested review from
fabianschuiki and
dtzSiFive
and removed request for
seldridge,
darthscsi and
dtzSiFive
uenoku
commented
Jun 12, 2024
uenoku
force-pushed
the
dev/hidetou/integeration
branch
from
35cf536
to
0a5146a
Compare
fabianschuiki
approved these changes
Jun 12, 2024
14 tasks
uenoku
changed the title
uenoku
force-pushed
the
dev/hidetou/integeration
branch
from
0a5146a
to
6121091
Compare
…ate C-compatible types
uenoku
force-pushed
the
dev/hidetou/integeration
branch
from
6121091
to
15fbeb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies ExportVerilog to emit two state types (
bitin general) for DPI import op. Furthermore, for specific bit width (8, 16, 32 and 64) it emits C-types (byte, shortint, int and longint).This PR also rejects small integer types other than 8, 16, 32 and 64 bit width since otherwise we have to use
bitbut they are passed by references in DPI. So this PR defines the ABI as "small integers are passed by values, and larger integers are passed by references.