[FIRRTL][ExpandWhens] Add StmtExprVisitor to Visitor and Support DPI intrinsic in ExpandWhens #7177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…intrinsic in ExpandWhens This adds `StmtExprVisitor` struct for visitor to handle operations with an optional result. Currently GenericIntrinsicOp and DPICallIntrinsicOp are added. Besides that DPI intrinsic is handled in ExpandWhens
uenoku
changed the title
dtzSiFive
approved these changes
Jun 14, 2024
| @@ -344,6 +344,48 @@ class DeclVisitor { | |||
| #undef HANDLE | |||
| }; | |||
|
|
|||
| /// StmtExprVisitor is a visitor for FIRRTL operation that has an optional | |||
| /// result. | |||
| template <typename ConcreteType, typename ResultType = void, | |||
There was a problem hiding this comment.
Awesome, thanks for breaking this out now that we have more than one 👍.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
StmtExprVisitorstruct for visitor to handle operations with an optional result. CurrentlyGenericIntrinsicOpandDPICallIntrinsicOpare added.Besides that
ExpandWhensis modified to handle DPI intrinsic.