[FIRRTL][CheckCombLoops] Verify that detection works with region ops #7198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youngar
force-pushed
the
firrtl-comb-loop-whens
branch
from
3b1568c
to
e34357b
Compare
youngar
force-pushed
the
firrtl-comb-loop-whens
branch
from
e34357b
to
61116c0
Compare
youngar
changed the title
dtzSiFive
approved these changes
Jun 18, 2024
|
|
||
| // ----- | ||
|
|
||
| // Single-element combinational loop with multiple connects. |
There was a problem hiding this comment.
This is more about last-connect than checking re:region ops but good to have it as well.
Distills that behavior separate from interaction/handling of things like when. 👍
darthscsi
approved these changes
Jun 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.