[CIR][CIRGen][Builtin][X86] Lower cvt*2mask intrinsics #1894
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RiverDave
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
RiverDave
force-pushed
the
dave/lower-vec-to-mask
branch
from
64c0407 to
12776fd
Compare
bcardosolopes
approved these changes
Sep 5, 2025
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
RiverDave
force-pushed
the
dave/lower-vec-to-mask
branch
from
12776fd to
069acc8
Compare
RiverDave
force-pushed
the
dave/lower-vec-to-mask
branch
from
069acc8 to
2bbab3c
Compare
tommymcm
pushed a commit
to tommymcm/clangir
that referenced
this pull request
Sep 10, 2025
Three things: - Corrected comments to `getZeroInitAttr` as [we return more than only integrals in that function](https://github.com/llvm/clangir/blob/2ea4005fa0aa291295b19c200860b5edf9b864b3/clang/include/clang/CIR/Dialect/Builder/CIRBaseBuilder.h#L133). - Given that `emitX86MaskedCompare` and `emitX86MaskedCompareResult` helpers are pretty large, Added NYI statements on paths not related to the current set of intrinsics so review is specific to the ones encoded. - Added test comments related to the behavior observed coming from the canonicalizer on: llvm#1770
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Three things:
getZeroInitAttras we return more than only integrals in that function.emitX86MaskedCompareandemitX86MaskedCompareResulthelpers are pretty large, Added NYI statements on paths not related to the current set of intrinsics so review is specific to the ones encoded.