[CIR] Add BlockAddrInfoAttr for LabelOp and BlockAddressOp #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andres-Salamanca
requested review from
lanza,
bcardosolopes,
xlauko and
andykaylor
as code owners
Andres-Salamanca
changed the title
| An identifier which may be referred by cir.goto operation | ||
| }]; | ||
| let arguments = (ins StrAttr:$label); | ||
| let arguments = (ins CIR_BlockAddrInfoAttr:$label); |
There was a problem hiding this comment.
Feels a redundant to store the entire CIR_BlockAddrInfoAttr given that the function_name will always be the function where the cir.label resides. You could have a method here in extraClassDeclaration that could just return a newly built CIR_BlockAddrInfoAttr, e.g.
BlockAddrInfoAttr getBlockAddressInfo() {
StringRef fnName = ... // this->getAnyParentOf<FuncOp>(...)
return BlockAddrInfoAttr::get(fnName, getLabel());
}
If it makes things easier, you could also create a CIR_LabelAttr (which is basically a StrAttr), but not clear if that brings any advantages.
There was a problem hiding this comment.
I reverted the changes to LabelOp. I don’t think it’s worth introducing an extra function, since calling cir::BlockAddrInfoAttr::get is sufficient. and in the CGF we have curFun, so we can get the funcName from there.
bcardosolopes
approved these changes
Sep 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new attribute
CIR_BlockAddrInfoAttr, requested in #1909, which is used inBlockAddressOpandLabelOp. I also created a custom builder to simplify construction so that we don’t have to callmlir::FlatSymbolRefAttr::getandmlir::StringAttr::getevery time.