Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][Bugfix] Fix cir.array getTypeSizeInBits method #206

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

sitio-couto
Copy link
Collaborator

@sitio-couto sitio-couto commented Aug 2, 2023

Stack from ghstack (oldest at bottom):

Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

[ghstack-poisoned]
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

[ghstack-poisoned]
@sitio-couto sitio-couto merged commit 614adaa into gh/sitio-couto/38/base Aug 7, 2023
sitio-couto added a commit that referenced this pull request Aug 7, 2023
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
@sitio-couto sitio-couto deleted the gh/sitio-couto/38/head branch August 7, 2023 15:06
lanza pushed a commit that referenced this pull request Oct 27, 2023
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
lanza pushed a commit that referenced this pull request Dec 20, 2023
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
lanza pushed a commit that referenced this pull request Jan 29, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
lanza pushed a commit to lanza/llvm-project that referenced this pull request Feb 8, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm/clangir#206
lanza pushed a commit that referenced this pull request Mar 23, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm#206
lanza pushed a commit that referenced this pull request Apr 29, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
lanza pushed a commit that referenced this pull request Apr 29, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm#206
lanza pushed a commit that referenced this pull request Apr 29, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
pysuxing pushed a commit to pysuxing/llvm-project that referenced this pull request Jul 17, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm/clangir#206
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm#206
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: llvm#206
lanza pushed a commit that referenced this pull request Nov 5, 2024
Constant initialization of static local arrays would fail due to a
mismatch between the variable and the initializer type size. This patch
fixes the data layout interface implementation for the cir.array type.

A complete array in C/C++ should have its type size in bits equal to
the size of the array times the size of the element type.

ghstack-source-id: 56f3f2918b23309210ad026017bafa37ca03b2d4
Pull Request resolved: #206
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants