Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][Codegen] VTT support for virtual class inheritance #252

Merged
merged 1 commit into from
Sep 13, 2023
Merged

Conversation

htyu
Copy link
Contributor

@htyu htyu commented Sep 7, 2023

This patch brings up the basic support for C++ virtual inheritance. VTT (virtual table table) now can be laid out as expected for simple program with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to take a last look after you update the PR, but otherwise good to go.

clang/lib/CIR/CodeGen/CIRGenVTables.cpp Show resolved Hide resolved
clang/lib/CIR/CodeGen/CIRGenVTables.h Outdated Show resolved Hide resolved
clang/test/CIR/CodeGen/vbase.cpp Outdated Show resolved Hide resolved
@htyu htyu force-pushed the vbase branch 2 times, most recently from 7337804 to d90fa50 Compare September 13, 2023 22:55
Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one more minor change

clang/lib/CIR/CodeGen/CIRGenClass.cpp Show resolved Hide resolved
@htyu htyu merged commit 470aba9 into llvm:main Sep 13, 2023
lanza pushed a commit that referenced this pull request Oct 27, 2023
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Dec 20, 2023
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Jan 29, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Mar 23, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
lanza pushed a commit that referenced this pull request Apr 29, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
This patch brings up the basic support for C++ virtual inheritance. VTT
(virtual table table) now can be laid out as expected for simple program
with single virtual inheritance. RTTI support is on the way.

This patch does not include LLVM lowering support.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants