[CIR][CIRGen] Add support for builtin bit operations #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
requested changes
Feb 21, 2024
There was a problem hiding this comment.
Nice!
This mostly looks good, some cosmetic changes requested. Some food for thought for a future PR: do you think these could use the same technique from #434 ?
|
I made some changes in the latest commit. I removed the verification of input integer width, because I think these restrictions are unnecessarily strict and may prevent standard library bit operations from being lowered to |
I rather see a more restrictive version until we have the optimization that does such lowering for library related ops. At that point we can relax based on what we see fit. |
bcardosolopes
requested changes
Feb 23, 2024
OK. I restored the type constraints on the input integer. |
bcardosolopes
approved these changes
Feb 29, 2024
This patch adds CIRGen support for the following built-in bit operations:
-`__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This patch adds a new operation, `cir.bits`, to represent such bit operations on
the input integers. LLVMIR lowering support is not included in this patch.
Rename CIR bit operations to cir.bit.*
Move all verification code into TableGen
|
@bcardosolopes Rebased onto the latest |
lanza
pushed a commit
that referenced
this pull request
Mar 23, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Mar 24, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
eZWALT
pushed a commit
to eZWALT/clangir
that referenced
this pull request
Apr 29, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
lanza
pushed a commit
that referenced
this pull request
Apr 29, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
bruteforceboy
pushed a commit
to bruteforceboy/clangir
that referenced
this pull request
Oct 2, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
lanza
pushed a commit
that referenced
this pull request
Nov 5, 2024
This PR adds CIRGen support for the following built-in bit operations:
- `__builtin_ffs{,l,ll,g}`
- `__builtin_clz{,l,ll,g}`
- `__builtin_ctz{,l,ll,g}`
- `__builtin_clrsb{,l,ll,g}`
- `__builtin_popcount{,l,ll,g}`
- `__builtin_parity{,l,ll,g}`
This PR adds a new operation, `cir.bits`, to represent such bit
operations on the input integers. LLVMIR lowering support is not
included in this PR.
> [!NOTE]
> As a side note, C++20 adds the `<bit>` header which includes some bit
operation functions with similar functionalities to the built-in
functions mentioned above. However, these standard library functions
have slightly different semantics than the built-in ones and this PR
does not include support for these standard library functions. Support
for these functions may be added later, or amended into this PR if the
reviewers request so.
Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds CIRGen support for the following built-in bit operations:
__builtin_ffs{,l,ll,g}__builtin_clz{,l,ll,g}__builtin_ctz{,l,ll,g}__builtin_clrsb{,l,ll,g}__builtin_popcount{,l,ll,g}__builtin_parity{,l,ll,g}This PR adds a new operation,
cir.bits, to represent such bit operations on the input integers. LLVMIR lowering support is not included in this PR.Note
As a side note, C++20 adds the
<bit>header which includes some bit operation functions with similar functionalities to the built-in functions mentioned above. However, these standard library functions have slightly different semantics than the built-in ones and this PR does not include support for these standard library functions. Support for these functions may be added later, or amended into this PR if the reviewers request so.