Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][CIRGen] Enable support of bool increment #493

Merged
merged 1 commit into from
Mar 12, 2024

Conversation

YazZz1k
Copy link
Contributor

@YazZz1k YazZz1k commented Mar 4, 2024

CIRGenFunction::buildFromMemory can handle the cir.bool values. So we no longer need to emit the NIY error here.

Copy link
Member

@bcardosolopes bcardosolopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

clang/test/CIR/CodeGen/inc-bool.c Outdated Show resolved Hide resolved
@bcardosolopes bcardosolopes merged commit 6d2c8ae into llvm:main Mar 12, 2024
6 checks passed
lanza pushed a commit that referenced this pull request Mar 23, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Mar 24, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
lanza pushed a commit that referenced this pull request Apr 29, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
lanza pushed a commit that referenced this pull request Apr 29, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
eZWALT pushed a commit to eZWALT/clangir that referenced this pull request Apr 29, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
lanza pushed a commit that referenced this pull request Apr 29, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
lanza pushed a commit that referenced this pull request Nov 5, 2024
CIRGenFunction::buildFromMemory can handle the `cir.bool` values. So we
no longer need to emit the `NIY` error here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants