Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CIR][Lowering] Add long double types for cos operation lowering #568

Merged
merged 2 commits into from
Apr 26, 2024

Conversation

zhoujingya
Copy link
Contributor

Add left long double types lowering for cos operation #565

Signed-off-by: zhoujing <jing.zhou@terapines.com>
@zhoujingya zhoujingya changed the title [CIR][Lowering] Add MLIR lowering support for CIR cos operations [CIR][Lowering] Add long double types for cos operation lowering Apr 26, 2024
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits on tests

clang/test/CIR/Lowering/ThroughMLIR/cos.cir Outdated Show resolved Hide resolved
Signed-off-by: zhoujing <jing.zhou@terapines.com>
Copy link
Member

@Lancern Lancern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bcardosolopes bcardosolopes merged commit d5743b3 into llvm:main Apr 26, 2024
6 checks passed
lanza pushed a commit that referenced this pull request Apr 29, 2024
Add left long double types lowering for cos operation #565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza pushed a commit that referenced this pull request Apr 29, 2024
Add left long double types lowering for cos operation #565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza pushed a commit that referenced this pull request Apr 29, 2024
Add left long double types lowering for cos operation #565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
bruteforceboy pushed a commit to bruteforceboy/clangir that referenced this pull request Oct 2, 2024
…m#568)

Add left long double types lowering for cos operation llvm#565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
Hugobros3 pushed a commit to shady-gang/clangir that referenced this pull request Oct 2, 2024
…m#568)

Add left long double types lowering for cos operation llvm#565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
keryell pushed a commit to keryell/clangir that referenced this pull request Oct 19, 2024
…m#568)

Add left long double types lowering for cos operation llvm#565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
lanza pushed a commit that referenced this pull request Nov 5, 2024
Add left long double types lowering for cos operation #565

---------

Signed-off-by: zhoujing <jing.zhou@terapines.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants