[CIR][Lowering] Add the concept of simple lowering and use it for unary fp2fp operations #806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcardosolopes
approved these changes
Aug 26, 2024
| @@ -38,8 +38,13 @@ include "mlir/IR/CommonAttrConstraints.td" | |||
| // CIR Ops | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| class LoweringInfo { | |||
There was a problem hiding this comment.
Add a comment here explaining that this is used to communicate to tablegen some direct lowering approach and perhaps an example of how it can be used.
| @@ -38,8 +38,13 @@ include "mlir/IR/CommonAttrConstraints.td" | |||
| // CIR Ops | |||
| //===----------------------------------------------------------------------===// | |||
|
|
|||
| class LoweringInfo { | |||
| bit simpleLowering = 0; | |||
| string llvmOpName; | |||
There was a problem hiding this comment.
How about we just have a single string simpleLoweringLLVMOpName = "" variable, and if it's defined to anything other than empty it implies simple lowering?
There was a problem hiding this comment.
Yeah I'm thinking about exactly the same thing... Updated.
bcardosolopes
changed the title
…ment FP intrincis
Lancern
force-pushed
the
simple-lowering
branch
from
1d4987a
to
c3afb00
Compare
bcardosolopes
approved these changes
Aug 27, 2024
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…ry fp2fp operations (llvm#806) This PR is the continuation and refinement of PR llvm#434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo. This PR basically just rebases llvm#434 onto the latest `main`. I also updated some naming used in the original PR to keep naming styles consistent. Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…ry fp2fp operations (llvm#806) This PR is the continuation and refinement of PR llvm#434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo. This PR basically just rebases llvm#434 onto the latest `main`. I also updated some naming used in the original PR to keep naming styles consistent. Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…ry fp2fp operations (llvm#806) This PR is the continuation and refinement of PR llvm#434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo. This PR basically just rebases llvm#434 onto the latest `main`. I also updated some naming used in the original PR to keep naming styles consistent. Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…ry fp2fp operations (llvm#806) This PR is the continuation and refinement of PR llvm#434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo. This PR basically just rebases llvm#434 onto the latest `main`. I also updated some naming used in the original PR to keep naming styles consistent. Co-authored-by: Nikolas Klauser <nikolasklauser@berlin.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the continuation and refinement of PR #434 which is originally authored by @philnik777 . Does not update it in-place since I don't have commit access to Nikolas' repo.
This PR basically just rebases #434 onto the latest
main. I also updated some naming used in the original PR to keep naming styles consistent.