[CIR][driver] Forward -fno-clangir-direct-lowering option to cc1 #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smeenai
requested changes
Sep 6, 2024
bcardosolopes
requested changes
Sep 9, 2024
|
Yes, back on it... |
|
I tried applying a suggestion but missed a semicolon: Please include that in your updates so that the tests can pass |
Of course. 😄 |
Allow from the clang driver the use of lowering from CIR to MLIR standard dialect. Update the test to match the real output when -fno-clangir-direct-lowering is used.
Co-authored-by: Shoaib Meenai <shoaib.meenai@gmail.com>
keryell
force-pushed
the
ronan/forward-fno-clangir-direct-lowering-to-cc1
branch
from
8132aa7
to
f373200
Compare
bcardosolopes
approved these changes
Sep 10, 2024
|
Note the ubuntu error is unrelated to this PR: #829, waiting for windows results to merge |
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
…m#822) Allow from the clang driver the use of lowering from CIR to MLIR standard dialect. Update the test to match the real output when `-fno-clangir-direct-lowering` is used, or with a combination of both `-fclangir-direct-lowering` and `-fno-clangir-direct-lowering`. --------- Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com> Co-authored-by: Shoaib Meenai <shoaib.meenai@gmail.com>
smeenai
added a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…m#822) Allow from the clang driver the use of lowering from CIR to MLIR standard dialect. Update the test to match the real output when `-fno-clangir-direct-lowering` is used, or with a combination of both `-fclangir-direct-lowering` and `-fno-clangir-direct-lowering`. --------- Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com> Co-authored-by: Shoaib Meenai <shoaib.meenai@gmail.com>
smeenai
added a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
…m#822) Allow from the clang driver the use of lowering from CIR to MLIR standard dialect. Update the test to match the real output when `-fno-clangir-direct-lowering` is used, or with a combination of both `-fclangir-direct-lowering` and `-fno-clangir-direct-lowering`. --------- Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com> Co-authored-by: Shoaib Meenai <shoaib.meenai@gmail.com>
keryell
added a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
…m#822) Allow from the clang driver the use of lowering from CIR to MLIR standard dialect. Update the test to match the real output when `-fno-clangir-direct-lowering` is used, or with a combination of both `-fclangir-direct-lowering` and `-fno-clangir-direct-lowering`. --------- Co-authored-by: Bruno Cardoso Lopes <bcardosolopes@users.noreply.github.com> Co-authored-by: Shoaib Meenai <shoaib.meenai@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow from the clang driver the use of lowering from CIR to MLIR standard dialect.
Update the test to match the real output when
-fno-clangir-direct-loweringis used, or with a combination of both-fclangir-direct-loweringand-fno-clangir-direct-lowering.