[CIR][Asm] Fix parsing of extra(...) attributes in cir.call #835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keryell
force-pushed
the
ronan/fix-callop-extra-parse
branch
from
6e73c59
to
0f6c518
Compare
seven-mile
suggested changes
Sep 13, 2024
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type. This was breaking the LSP-server for example. Change the parser behavior accordingly.
keryell
force-pushed
the
ronan/fix-callop-extra-parse
branch
from
0f6c518
to
41ebe96
Compare
Surprise! LSP server is choking on |
This should be fixed with #847 |
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type. This was breaking the LSP-server for example. Change the parser behavior accordingly.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type. This was breaking the LSP-server for example. Change the parser behavior accordingly.
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type. This was breaking the LSP-server for example. Change the parser behavior accordingly.
keryell
added a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type. This was breaking the LSP-server for example. Change the parser behavior accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parser was looking for extra(...) before the return type while the pretty-printer put it after the return type.
This was breaking the LSP-server for example.
Change the parser behavior accordingly.