[CIR][ABI] Apply CC lowering pass by default #842

sitio-couto · 2024-09-14T17:27:52Z

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the -fno-clangir-call-conv-lowering flag if necessary.

The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation.

From an implementation perspective, several llvm_unreachable statements have been substituted with a new assert_or_abort macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does.

A few notable changes:

Support multi-block function in CC lowering
Ignore pointer-related CC lowering
Ignore no-proto functions CC lowering
Handle missing type evaluation kinds
Fix CC lowering for function declarations
Unblock indirect function calls
Disable CC lowering pass on several tests

bcardosolopes

Thanks a bunch for working on this. Mostly nits in this round but approach LGTM (will merge once fixed)

clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerCall.cpp

clang/lib/CIR/Dialect/Transforms/TargetLowering/LowerFunction.cpp

clang/include/clang/CIR/MissingFeatures.h

clang/include/clang/Driver/Options.td

bcardosolopes · 2024-09-16T18:04:25Z

There are formatting changes needed, but for tests seems like you are hitting #829, so feel free to ignore that one.

bcardosolopes · 2024-09-18T21:46:07Z

Conflicts + some tests failing still (probably because of recent merges).

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

sitio-couto · 2024-09-21T14:05:11Z

@bcardosolopes applied.

clang/include/clang/CIR/MissingFeatures.h

…ing through MLIR

…t-cir-flat

sitio-couto · 2024-09-24T00:27:21Z

@bcardosolopes applied.

bcardosolopes

LGTM, I'll land this tomorrow, so I'll apply a similar change downstream to disable this flag, sorry for the delay

Fix #895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

Fix llvm#895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

This reverts commit 8f699fd.

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

Fix llvm#895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

Fix llvm#895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

Fix llvm#895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

This reverts commit 8f699fd.

…" (#944) This reverts commit 8f699fd and fixes some issues, namely: - CC lowering pass will no longer fail if the function has no AST information that won't be used. - Fixed CC lowering not disabling when running certain `cc1` compilation commands. - CC lowering can now be disabled when calling `cir-opt` and `cir-translate`. - Compilation commands that generate Object files should now invoke CC lowering by default.

Before this patch, the CC lowering pass was applied only when explicitly requested by the user. This update changes the default behavior to always apply the CC lowering pass, with an option to disable it using the `-fno-clangir-call-conv-lowering` flag if necessary. The primary objective is to make this pass a mandatory step in the compilation pipeline. This ensures that future contributions correctly implement the CC lowering for both existing and new targets, resulting in more consistent and accurate code generation. From an implementation perspective, several `llvm_unreachable` statements have been substituted with a new `assert_or_abort` macro. This macro can be configured to either trigger a non-blocking assertion or a blocking unreachable statement. This facilitates a test-by-testa incremental development as it does not required you to know which code path a test will trigger an just cause a crash if it does. A few notable changes: - Support multi-block function in CC lowering - Ignore pointer-related CC lowering - Ignore no-proto functions CC lowering - Handle missing type evaluation kinds - Fix CC lowering for function declarations - Unblock indirect function calls - Disable CC lowering pass on several tests

Fix llvm#895 and it's also missing some more throughout behavior for the pass, it also needs to be enabled by default when emitting object files. This reverts commit db6b7c0.

…#842)" (llvm#944) This reverts commit 8f699fd and fixes some issues, namely: - CC lowering pass will no longer fail if the function has no AST information that won't be used. - Fixed CC lowering not disabling when running certain `cc1` compilation commands. - CC lowering can now be disabled when calling `cir-opt` and `cir-translate`. - Compilation commands that generate Object files should now invoke CC lowering by default.

sitio-couto self-assigned this Sep 14, 2024

sitio-couto requested review from lanza and bcardosolopes as code owners September 14, 2024 17:27

bcardosolopes approved these changes Sep 16, 2024

View reviewed changes

lanza force-pushed the main branch from 67ce904 to 845c25a Compare September 19, 2024 03:42

sitio-couto added 9 commits September 21, 2024 06:49

Track missing VarArg handling in ABI lowering using an assertion

a48ccc6

Create ABIParameterCoercion missing feature

00b7b36

Rename ASSERT_mode to cirMissingFeatureAssertionMode

634e5ef

Rename assert_or_abort to cir_assert_or_abort

b65590c

Add note mentioning CC lowering flag is temporary

5574bcb

Fix formatting issues

c346cf1

Fix left over assert_or_abort statament

289ef0f

Disable CC lowering on a few more tests

21e78b1

sitio-couto force-pushed the vinicius/run-cc-lowering-by-default branch from c748b22 to 21e78b1 Compare September 21, 2024 10:13

bcardosolopes requested changes Sep 23, 2024

View reviewed changes

clang/include/clang/CIR/MissingFeatures.h Outdated Show resolved Hide resolved

sitio-couto added 3 commits September 23, 2024 19:31

Ensure asserts in TargetLowering lib have a special note

7736e57

Apply CC lowering only when --emit-cir-flat and by default when lower…

ded4eb9

…ing through MLIR

Remove -fno-clangir-call-conv-lowering from test that don't use --emi…

b0768a4

…t-cir-flat

smeenai requested a review from bcardosolopes September 27, 2024 04:03

bcardosolopes approved these changes Sep 27, 2024

View reviewed changes

bcardosolopes merged commit db6b7c0 into llvm:main Sep 28, 2024
6 checks passed

sitio-couto deleted the vinicius/run-cc-lowering-by-default branch September 28, 2024 19:11

sitio-couto added a commit to sitio-couto/clangir that referenced this pull request Oct 7, 2024

Reapply "[CIR][ABI] Apply CC lowering pass by default (llvm#842)"

c2c440c

This reverts commit 8f699fd.

sitio-couto added a commit to sitio-couto/clangir that referenced this pull request Oct 10, 2024

Reapply "[CIR][ABI] Apply CC lowering pass by default (llvm#842)"

d564e9a

This reverts commit 8f699fd.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CIR][ABI] Apply CC lowering pass by default #842

[CIR][ABI] Apply CC lowering pass by default #842

sitio-couto commented Sep 14, 2024

bcardosolopes left a comment

bcardosolopes commented Sep 16, 2024

bcardosolopes commented Sep 18, 2024

sitio-couto commented Sep 21, 2024

sitio-couto commented Sep 24, 2024

bcardosolopes left a comment

[CIR][ABI] Apply CC lowering pass by default #842

[CIR][ABI] Apply CC lowering pass by default #842

Conversation

sitio-couto commented Sep 14, 2024

bcardosolopes left a comment

Choose a reason for hiding this comment

bcardosolopes commented Sep 16, 2024

bcardosolopes commented Sep 18, 2024

sitio-couto commented Sep 21, 2024

sitio-couto commented Sep 24, 2024

bcardosolopes left a comment

Choose a reason for hiding this comment