[CIR][CIRGen][Builtin][Neon] Lower __builtin_neon_vrndns_f32 #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghehg
commented
Sep 18, 2024
ghehg
commented
Sep 18, 2024
bcardosolopes
changed the title
bcardosolopes
requested changes
Sep 18, 2024
| // CIR: cir.store %arg0, [[ARG_SAVE:%.*]] : !cir.float, !cir.ptr<!cir.float> | ||
| // CIR: [[INTRIN_ARG:%.*]] = cir.load [[ARG_SAVE]] : !cir.ptr<!cir.float>, !cir.float | ||
| // CIR: [[INTRIN_RES:%.*]] = cir.llvm.intrinsic "llvm.roundeven.f32" [[INTRIN_ARG]] : (!cir.float) | ||
| // TODO: Add check making sure below return actually gets value from the intrinsic call. |
There was a problem hiding this comment.
You can remove the TODO here, the redundant load/store for return is a common pattern in CIR and we are not really testing anything about cir.return, checking the cir.return is useful here to delimit the test boundary, nothing more.
| llvm_unreachable("NYI"); | ||
| mlir::Value arg0 = buildScalarExpr(E->getArg(0)); | ||
| args.push_back(arg0); | ||
| return buildAArch64NeonCall(NEON::BI__builtin_neon_vrndns_f32, *this, |
There was a problem hiding this comment.
Rename buildAArch64NeonCall to buildNeonCall. If there's anything AArch64 specific in its behavior, should be checked / asserted inside the function.
bcardosolopes
approved these changes
Sep 19, 2024
Hugobros3
pushed a commit
to shady-gang/clangir
that referenced
this pull request
Oct 2, 2024
As title. Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics. --------- Co-authored-by: Guojin He <guojinhe@meta.com>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
As title. Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics. --------- Co-authored-by: Guojin He <guojinhe@meta.com>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
As title. Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics. --------- Co-authored-by: Guojin He <guojinhe@meta.com>
smeenai
pushed a commit
to smeenai/clangir
that referenced
this pull request
Oct 9, 2024
As title. Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics. --------- Co-authored-by: Guojin He <guojinhe@meta.com>
keryell
pushed a commit
to keryell/clangir
that referenced
this pull request
Oct 19, 2024
As title. Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics. --------- Co-authored-by: Guojin He <guojinhe@meta.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title.
Also introduced buildAArch64NeonCall skeleton, which is partially the counterpart of OG's EmitNeonCall. And this could be use for many other neon intrinsics.